-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor discharge_reason data type to Integer #6807
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #1854 ↗︎
Details:
Review all test suite changes for PR #6807 ↗︎ |
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@Ashesh3 clear the merge conflict and follow up on the backend PR |
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
test to complete
|
|
Note: Discharge reason filter on Patient List page is non functional - Pending merge of ohcnetwork/care#1818 |
LGTM |
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Backend PR: ohcnetwork/care#1773
WHAT
🤖[deprecated] Generated by Copilot at 5693149
The pull request refactors and updates the code related to discharge reasons in various components and interfaces. It uses a constant
DISCHARGE_REASONS
for the discharge reasons and changes the type of thedischarge_reason
property to a number or null to align with the backend API. This improves the code consistency, clarity, and maintainability.Proposed Changes
discharge_reason
toIntegerField
care#1739@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖[deprecated] Generated by Copilot at 5693149
discharge_reason
from string to number or null in various interfaces, components, and states to match the backend API and avoid type errors (link, link, link, link, link, link, link)DISCHARGE_REASONS
constant fromsrc/Common/constants.tsx
in various components to improve readability and maintainability and avoid errors due to typos or changes in the discharge reasons (link, link, link, link, link, link, link, link, link, link, link, link, link)TextFormField
andTextAreaFormField
components in theDischargeModal
component based on thedischarge_reason
value using numbers and an object literal to access the corresponding text (link, link, link, link, link, link)